Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reliability and modernisation improvements #13

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

fetwar
Copy link

@fetwar fetwar commented Jun 11, 2024

I recently used this in a project and made some refinements to it.

Changes:

  • more clarifying comments & logging
  • removed obsolete or unsupported options
    • version in docker-compose.yml
    • --unattended in config.sh remove
      • this was throwing a warning every time on cleanup
  • improved docker usage
    • docker secrets instead of read only bind mount for PAT
    • added a health check to the socket service
    • disabled auto updates of runners
      • previously each runner would update itself every time before running, independently downloading and executing the install

If you'd prefer I can break these down into separate PRs, just let me know.

Any feedback is greatly appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant