Cmakeupdates #46
Cmakeupdates #46
Conversation
…icates, avoid including carlLogging header if not necessary)
… to effective forward declarations
| @@ -76,31 +75,37 @@ option( PRUNE_MONOMIAL_POOL "Prune monomial pool" ON ) | |||
| option( EXCLUDE_TESTS_FROM_ALL "If set, tests will not be compiled by default" OFF ) | |||
| export_option(EXCLUDE_TESTS_FROM_ALL) | |||
|
|
|||
| option( CARL_COMPILE_RELEASE "Compile in Release mode irrespectively of CMAKE_BUILD_TYPE" OFF) | |||
There was a problem hiding this comment.
Why do we need a separate flag?
There was a problem hiding this comment.
So this is actually not advised to do, but it would allow you to compile carl in release mode while compiling storm in debug mode (or vice versa), when carl is a subproject.
I am also happy not to support that :-D
There was a problem hiding this comment.
Ok, just wanted to confirm that my understanding is correct.
I would be in favour of removing it, because in most cases one would like to have both with the same build type. If different build types are needed, one can still manually build carl.
(The flag is currently also not used anywhere as far as I can see.)
|
Installing carl-storm worked for me without any issue. |
This PR changes the cmakefiles to support building carl as a subproject (not a toplevel project) in other projects, most notably storm.