Remove Python v2 guards #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Originally, I wasn't sure whether I'd ever support Python v2 in this library (#2). Now I'm sure that I'm not going to, so I've removed the existing guards.
What approach did you choose and why?
Removed the
PY_MAJOR_VERSIONguards inmodule.cI didn't remove the guards in
_datetimemodule.cnortimezone.csince those are effectively vendored/shared withciso8601, so keeping the guards in makes it easier to keep those in sync.What should reviewers focus on?
That I didn't mess up the indentation in the process.
The impact of these changes
Less code, less problems. No externally visible changes.