Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tutorial for warehouse_ros(_sqlite) #101
Add tutorial for warehouse_ros(_sqlite) #101
Changes from 2 commits
16949db
d7b2c2a
25e8df7
8d82990
cfce8a3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the current MoveIt launch file code in ROS2 (In my naive opinion it's a horrible and entirely useless pile of crap that does not scale), so I can't review this file at all.
Please review this file @JafarAbdi @henningkayser
Do you really add these whole stacks to each and every tutorial?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All launch files will be simplified once moveit/moveit2#591 is merged. No need to adapt this launch file, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it makes sense to highlight this as the default.
If anything most new users of these methods will default to the simpler sqlite backend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but then we have to change all the demo files and the templates for the MSA. This would be a breaking change, maybe postpone it to the next distro (H Turtle)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no official MSA for MoveIt2 yet, so we still have all the flexibility there as far as I know. :)
But yes, in MoveIt the config templates mention mongodb in multiple places, so de facto that makes it the default.
However, I would still prefer to remove the
(default)
part to not bias potential users into thinking mongodb might be better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the user experience is really horrible with this GUI... I just tried to use this for something productive.
But of course reworking the GUI is outside of the scope of this.