Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade husky to v5, fix postinstall script #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Upgrade husky to v5, fix postinstall script #77

wants to merge 1 commit into from
+37 −12

Conversation

bostrom
Copy link
Member

@bostrom bostrom commented Mar 15, 2021

No description provided.

@bostrom bostrom requested a review from petetnt March 15, 2021 21:07
@bostrom
Copy link
Member Author

bostrom commented Mar 15, 2021

Needs proper testing still...

@petetnt
Copy link
Member

petetnt commented Mar 15, 2021

Husky v5 has The Parity Public License 7.0.0 instead of MIT which can be problematic in our projects so 👎 from me (though 👍 for sponsoring husky)

https://typicode.github.io/husky/#/?id=announcement

https://paritylicense.com/versions/7.0.0.html

@bostrom
Copy link
Member Author

bostrom commented Mar 16, 2021

Oh, damn

@bostrom bostrom closed this Mar 16, 2021
@bostrom bostrom deleted the update-husky branch March 16, 2021 07:21
@bostrom bostrom restored the update-husky branch April 11, 2021 17:21
@bostrom
Copy link
Member Author

bostrom commented Apr 11, 2021

Maybe we can revisit this now that husky is back at MIT?
https://github.com/typicode/husky/blob/main/LICENSE

@bostrom bostrom reopened this Apr 11, 2021
@bostrom
Copy link
Member Author

bostrom commented Apr 11, 2021

"prepare": "husky install", should be added to the scripts in package.json.

@petetnt
Copy link
Member

petetnt commented May 27, 2021

There's now Husky v6, that probably does some things differently too 🤕

I added #78 for considering going with simple-git-hooks instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petetnt petetnt Awaiting requested review from petetnt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bostrom @petetnt