merge dev to master #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmats #28 Extended `VideoStyle` to handle audio formats (e.g., MP3, AAC, WAV) and added functions to detect, validate, and assign extensions. Updated FFMpeg processing logic to differentiate between audio and video formats and introduced new tests for all supported formats.
The Utils function now trims leading dots from paths when constructing file names with a new extension. A corresponding unit test has been added to ensure proper behavior in cases where the directory name is null.
Updated the README to include the new feature allowing video files to be converted into custom video or audio formats. This highlights enhanced functionality for handling multimedia files.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 500 519 +19
===========================================
Files 54 54
Lines 1798 1834 +36
===========================================
+ Hits 1798 1834 +36 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for additional audio and video formats in the Larupload package. The key changes include the addition of new format classes, updates to handle these formats in various methods, and new tests to ensure proper functionality.
Support for new audio and video formats:
src/Concerns/Storage/Attachment/StyleAttachment.php: Added support for handling audio formats in thehandleVideoStylesmethod.src/Concerns/Storage/UploadEntity/UploadEntityStyle.php: Updated thevideomethod to accept new audio and video formats.src/DTOs/Style/VideoStyle.php: Added new audio format classes and methods to handle audio formats. [1] [2]Codebase improvements:
src/Storage/FFMpeg/FFMpeg.php: ImprovedgetMetaandmanipulatemethods to handle new formats and ensure duration is correctly retrieved. [1] [2]Testing enhancements:
tests/Feature/VideoStyleTest.php: Added tests to verify video generation with custom formats.tests/Unit/VideoStyleTest.php: Added tests to validate audio format handling and correct extension assignment.tests/Support/TestAttachmentBuilder.php: Added methods to support new custom format videos in tests. [1] [2]#28