-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and update Dockerfile #1220
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1220 +/- ##
=======================================
Coverage 84.85% 84.85%
=======================================
Files 53 53
Lines 4799 4800 +1
=======================================
+ Hits 4072 4073 +1
Misses 727 727 ☔ View full report in Codecov by Sentry. |
… push final image
dockerbuild |
\dockerbuild |
Well, I was trying to create a job that would test the docker build only when triggered to do so, either by a comment, or if Building the new dockerfile works for me locally. If it passes here after merging I'll make similar updates to foyer and gmso. |
PR Summary:
The docker build is failing after the change from
setup.py
topyproject.toml
. While fixing that, I figured we could switch to a mamba and ubuntu-based image (here) instead of an anaconda and alpine one (here) since the current workflow installs mamba anyway.