-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace setup.py
with pyproject.toml
, update actions to latest versions
#1217
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1217 +/- ##
==========================================
- Coverage 85.89% 84.85% -1.05%
==========================================
Files 53 53
Lines 4799 4799
==========================================
- Hits 4122 4072 -50
- Misses 677 727 +50 ☔ View full report in Codecov by Sentry. |
| It's not clear to me where setup.cfg fits into this now. Do we still need it for bumpversion? Looks like our two options moving forwards are: |
While we're doing this maintenance, is there anything we would want to add to a ruff.toml such as what HOOMD-blue is using https://github.com/glotzerlab/hoomd-blue/blob/trunk-patch/ruff.toml? |
We could use https://github.com/callowayproject/bump-my-version, it seems more actively maintained. As far as the |
PR Summary:
This replaces
setup.py
with apyproject.toml
file.I've been noticing these deprecation messages recently when running
pip install .
from source. I think it's recommended to usepyproject.toml
instead ofsetup.py
DEPRECATION: Legacy editable install of mbuild==1.0.0 from file:///home/chris/repos/mbuild (setup.py develop) is deprecated. pip 25.0 will enforce this behaviour change. A possible replacement is to add a pyproject.toml or enable --use-pep517, and use setuptools >= 64. If the resulting installation is not behaving as expected, try using --config-settings editable_mode=compat. Please consult the setuptools documentation for more information. Discussion can be found at https://github.com/pypa/pip/issues/11457
It's not clear to me where
setup.cfg
fits into this now. Do we still need it forbumpversion
?This also updates a couple actions to their latest versions.