fix: delete will from persistence on disconnect #957
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I was using aedes-persistence-redis and noticed that if clients connect with a will message then the keys weren't being deleted on a clean disconnect
Solution
The keys should always be removed from the persistence regardless if the the client disconnects cleanly or not. When the client disconnects, the will no longer should matter so we can delete it. If the client connects again with another will, then we can retain that one.