Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle persisting the dup flag #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle persisting the dup flag #79

wants to merge 1 commit into from

Conversation

robertsLando
Copy link
Member

Reference to moscajs/aedes#603

@robertsLando robertsLando requested a review from gnought February 11, 2022 12:40
@gnought
Copy link
Collaborator

gnought commented Feb 13, 2022

LGTM

@mcollina
Copy link
Collaborator

The original design of Aedes had this not persisted for a reason.

@robertsLando
Copy link
Member Author

robertsLando commented Feb 14, 2022 •
edited
Loading

@mcollina Could you explain? This is actually blocking moscajs/aedes#603. Any suggestions?

@mcollina
Copy link
Collaborator

I can't recall and don't have much room m time to investigate :/. Go ahead and land.

@robertsLando
Copy link
Member Author

@tomekt-bolt are you still interested in this? COuld you write a unit test that covers it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnought gnought Awaiting requested review from gnought

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robertsLando @gnought @mcollina @tomekt-bolt