Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upper bound for prefix_int #823

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

XiaohanZhangCMU
Copy link
Contributor

Description of changes:

prefix_int can go up from 0 to infinity. We want to cap it at a large value before it exhausts the compute resources.

Issue #, if available:

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

Copy link
Collaborator

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just want the error message a bit more cleaned up / clear. Otherwise lgtm

streaming/base/shared/prefix.py Outdated Show resolved Hide resolved
streaming/base/shared/prefix.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error comment still slightly confusing imo, approving though

if prefix_int >= MAX_PREFIX_INT:
raise ValueError(f'prefix_int exceeds {MAX_PREFIX_INT}. This may happen ' +
f'when you mock os.path.exists or os.stat functions so the filelock ' +
f'checks always returns `True` ' + f'you need to clean up TMPDIR.')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this what's intended?

Suggested change
f'checks always returns `True` ' + f'you need to clean up TMPDIR.')
f'checks always returns `True`. ' + f'You need to clean up TMPDIR.')

@snarayan21
Copy link
Collaborator

@XiaohanZhangCMU some linting errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants