Add varint to MDS #574
Open
Add varint to MDS #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snarayan21
reviewed
Jan 24, 2024
| for x in range(-700, 700, 7): | ||
| y = mds_encode('varint', x) | ||
| z = mds_decode('varint', y) | ||
| print(x, y, z) |
There was a problem hiding this comment.
do we need the print statements both here and below?
There was a problem hiding this comment.
Also, can we test ints and their expected lengths that we would encode through tokenization? For example, the vocab_size of many models customers train is between 50 and 150k. Testing ints in that range would be useful
There was a problem hiding this comment.
your spurious print statement life debt is paid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
varint,varuintencodings to MDS.