-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate ICL classes to foundry #936
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks absolutely fire, best PR I've seen in my whole life :)
Will let Max do the final vetting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks absolutely fire, best PR I've seen in my whole life :)
Will let Max do the final vetting.
It appears that a single svamp example was different btwn pre and post, so I reran some runs on svamp only. They produced the same results before/after the migration, so I am confident about our results there: |
…lm-foundry into migrate_subclasses_to_foundry
…lm-foundry into migrate_subclasses_to_foundry
Llama2 human_eval pre-migration
Llama2 human_eval post-migration
poorly named mpt pre-migration run:
mpt post-migration run:
|
With these results I approve the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eval is same before and after and I approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not review the code super closely, relying on Max's review for that. Results look good to me.
…lm-foundry into migrate_subclasses_to_foundry
* start * still need to migrate fixtures * wip onboarding tests * still workin' * still wip * maybe done; test out on mcli now * mcli * remove calibration error * migration * migration * full migration * precommit * fix * fix pytests * refactor QA * update * restore * add * fix * wip * update readme * final pyright * done * pass prelimiter into ALL the ICL task datasets * allow QA task name stil lfor backward compatibility * fix * fix test * add generation length * remove max_new_tokens * fix cpu trsts * try and fix lm eval test * temp disable lm task eval test * fix test? * fix tet * finish * fix * Update scripts/eval/README.md Co-authored-by: Daniel King <[email protected]> * fix comments * fix bug with seq len * restore mcli * merge * fix builder * add deprecation warning * add deprecation warning * merge * merge * add logging necessities to nlp.py * add attention_mask test update * fix generation_length in tests * fix bug * restore yamls * fix typos * add deprecation warning for code * pyright wip * fix pyright * fix pyright error again * fix pyright * fix pyright * update version --------- Co-authored-by: Eitan Turok <[email protected]> Co-authored-by: Max Marion <[email protected]> Co-authored-by: Daniel King <[email protected]> Co-authored-by: Max Marion <[email protected]>
DEPRECATING COMPOSER CLASSES: mosaicml/composer#3125
This PR migrates all the ICL(Dataset|Metric) classes (including the super classes, since composer no longer depends on them) It also migrates all the relevant tests, it renames the QATask to InContextLearningGenerationTaskWithAnswers (to capture the fact that it can and will be used for arbitrary generation tasks, such as summarization, and can even be used with LLM-as-judge).
Relatedly we need to remove or deprecate the equivalent classes in composer in order to avoid confusion and prevent people from trying to add new functionality to composer in the future.
Experimental runs:
mpt 7b:
mpt-eval-zDGaOU
Llama 2 7b:
llama2-eval-66Rw1B
Base run:
eval-gauntlet-pre-migration-mpt-N3lIuF
Base llama2:
eval-gauntlet-pre-migration-llama-imFgAZ
CODE
Pre-migration
llama2-code-pre-migration-D3fXGe
mpt7b-code-pre-migration-x8nPTd
Post-migration
llama2-code-post-migration-aSqFno
mpt7b-code-post-migration-3N0tKy