Enable streaming of local finetuning dataset #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @eldarkurtic , thanks for the change! Could you please run |
dakinggg
reviewed
Jan 17, 2024
| @@ -280,6 +280,11 @@ def _validate_config(dataset_cfg: DictConfig) -> None: | |||
| 'Using a streaming dataset requires setting both `remote` and `local`, ' +\ | |||
| 'but dataset.local is None.' | |||
| ) | |||
| else: | |||
| if dataset_cfg.get('split') not in os.listdir(dataset_cfg.local): | |||
There was a problem hiding this comment.
I don't think this is exactly the right condition. If remote is not None, then local won't contain the split folder (yet).
There was a problem hiding this comment.
Good catch. Will address comments in a day or so. Thanks for the feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current path for streaming of finetuning datasets does not allow for streaming from local path (which works for text datasets out of the box and is also supported by
StreamingFinetuningDatasetclass). Diff just updates the waylocalis considered when building finetuning dataloaders. It has been tested on MPT-7B finetuning from local streaming dolly_hhrlhf dataset.