Add model downloading from oras #857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irenedea
commented
Jan 11, 2024
| # This shouldn't actually download any files if the cache server download was successful, but should address | ||
| # a non-deterministic bug where the symlinks aren't repaired properly by the time the model is initialized. | ||
| log.info('Repairing Hugging Face cache symlinks') | ||
| if args.fallback == 'hf': |
There was a problem hiding this comment.
@jerrychen109 is it okay to condition on this?
There was a problem hiding this comment.
should we condition on the save_dir being the HF cache? symlinks are just for the HF cache, right?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ] | ||
|
|
||
| cmd_to_run_no_password = get_oras_cmd_to_run(ORAS_PASSWD_PLACEHOLDER) | ||
| log.info(f'CMD for oras cli to run: {cmd_to_run_no_password}') |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
irenedea
commented
Jan 11, 2024
| # This shouldn't actually download any files if the cache server download was successful, but should address | ||
| # a non-deterministic bug where the symlinks aren't repaired properly by the time the model is initialized. | ||
| log.info('Repairing Hugging Face cache symlinks') | ||
| if args.fallback == 'hf': |
There was a problem hiding this comment.
Suggested change
| if args.fallback == 'hf': | |
| if args.fallback == 'hf' and args.save_dir == HUGGINGFACE_HUB_CACHE: |
|
closing in favor of #881 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual tests
ift-mpt-7b-harbor-download-i8vxl8