Add how to use multiple streams in loaders in yaml #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
requested changes
Jan 4, 2024
| 1. [FAQ: How many GPUs do I need to train a LLM?](#howmandygpus) | ||
| 1. [FAQ: Optimizing Performance](#optimizingperformance) | ||
| - [LLM Pretraining and Finetuning](#llm-pretraining-and-finetuning) | ||
| - [Table of Contents](#table-of-contents) |
There was a problem hiding this comment.
I don't think we need the self reference to the table of contents here
|
|
||
| ```yaml | ||
| train_loader: | ||
| name: finetuning |
There was a problem hiding this comment.
the finetuning dataloader doesn't actually support streams. not for any technical reason, just haven't update it, but this example should be in the pretraining data section and use the text dataloader
There was a problem hiding this comment.
@cli99 mind finishing this PR real quick?
|
Done in another PR |
auto-merge was automatically disabled
April 4, 2024 21:35
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users asks for an example to use multiple streams (https://github.com/mosaicml/streaming?tab=readme-ov-file#seamless-data-mixing) through yaml file.