Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SIQA gold indices #774

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Fix SIQA gold indices #774

merged 2 commits into from
Dec 4, 2023

Conversation

bmosaicml
Copy link
Contributor

A slight bug in the dataset generation code resulted in erroneously writing that all questions had gold_idx=0. I fixed it to accurate indicate the correct answer indices.

@dakinggg dakinggg requested a review from maxisawesome December 4, 2023 17:47
@tbarton16 tbarton16 self-requested a review December 4, 2023 19:13
Copy link
Contributor

@tbarton16 tbarton16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxisawesome
Copy link
Contributor

pretty simple change, I approve

@bmosaicml bmosaicml enabled auto-merge (squash) December 4, 2023 19:35
@bmosaicml bmosaicml merged commit 61cd110 into main Dec 4, 2023
10 checks passed
@bmosaicml bmosaicml deleted the fix_siqa branch December 4, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants