Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add single value support to activation_checkpointing_target #772

Merged
merged 2 commits into from
Dec 1, 2023
Merged

add single value support to activation_checkpointing_target #772

merged 2 commits into from
Dec 1, 2023

Conversation

cli99
Copy link
Contributor

@cli99 cli99 commented Dec 1, 2023

This PR addes support to take a single value to activation_checkpointing_target
for example,

    activation_checkpointing_target: grouped_query_attention

is equivalent to

 activation_checkpointing_target: 
     - grouped_query_attention

@cli99 cli99 requested review from dakinggg and vchiley December 1, 2023 20:54
@cli99 cli99 enabled auto-merge (squash) December 1, 2023 21:16
@cli99 cli99 merged commit 6ac01ef into main Dec 1, 2023
10 checks passed
@dakinggg dakinggg deleted the act-ckpt-single-target branch February 3, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@vchiley vchiley vchiley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cli99 @vchiley @dakinggg