Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only strip object names when creating new output path #766

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Only strip object names when creating new output path #766

merged 4 commits into from
Nov 29, 2023

Conversation

irenedea
Copy link
Contributor

@irenedea irenedea commented Nov 29, 2023 •
edited
Loading

We should only strip for the call to os.path.join to prevent the following:

>>> os.path.join('foo', '/bar')
'/bar'

when we want the resulting path to be foo/bar

dakinggg
dakinggg approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a simple test please?

XiaohanZhangCMU
XiaohanZhangCMU approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@XiaohanZhangCMU XiaohanZhangCMU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@irenedea
Copy link
Contributor Author

@dakinggg added test 373e65b

@irenedea irenedea enabled auto-merge (squash) November 29, 2023 19:57
@irenedea irenedea merged commit 1191267 into mosaicml:main Nov 29, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@XiaohanZhangCMU XiaohanZhangCMU XiaohanZhangCMU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irenedea @XiaohanZhangCMU @dakinggg