Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to composer 0.17 #736

Merged
merged 8 commits into from
Nov 16, 2023
Merged

Bump to composer 0.17 #736

merged 8 commits into from
Nov 16, 2023

Conversation

dakinggg
Copy link
Collaborator

No description provided.

@dakinggg dakinggg requested a review from mvpatel2000 November 16, 2023 01:08
@dakinggg dakinggg marked this pull request as ready for review November 16, 2023 03:32
@dakinggg dakinggg requested a review from j316chuck November 16, 2023 03:33
j316chuck
j316chuck approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@j316chuck j316chuck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a nit for your consideration.

tests/test_mpt_gen.py Outdated Show resolved Hide resolved
tests/test_mpt_gen.py Show resolved Hide resolved
@dakinggg dakinggg merged commit e730995 into mosaicml:main Nov 16, 2023
12 checks passed
@dakinggg dakinggg deleted the composer-0.17 branch December 11, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j316chuck j316chuck j316chuck approved these changes

@mvpatel2000 mvpatel2000 Awaiting requested review from mvpatel2000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dakinggg @j316chuck