Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tokenizer_name field #735

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Remove tokenizer_name field #735

merged 1 commit into from
Nov 14, 2023

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Nov 14, 2023 •
edited
Loading

We forgot to remove the field from some yamls at some point. It is no longer used, as there is a separate tokenizer section responsible for building the tokenizer.

Test run using one of these yamls: mosaic-gpt-1b-gpus-8-JBpxrz

@dakinggg dakinggg marked this pull request as ready for review November 14, 2023 18:05
j316chuck
j316chuck approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@j316chuck j316chuck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Just wondering, this extra tokenizer name printed out in the warnings right?

@dakinggg dakinggg merged commit 45113eb into mosaicml:main Nov 14, 2023
12 checks passed
@dakinggg dakinggg deleted the remove-tokenizer-name branch December 11, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j316chuck j316chuck j316chuck approved these changes

@irenedea irenedea Awaiting requested review from irenedea

@mvpatel2000 mvpatel2000 Awaiting requested review from mvpatel2000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dakinggg @j316chuck