Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set persistent_workers = False for packing profiling #718

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Set persistent_workers = False for packing profiling #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
73b052c
persistent_workers=False
dakinggg Nov 7, 2023
b5b7bd3
error message
dakinggg Nov 7, 2023
7474843
add log
dakinggg Nov 7, 2023
2e4e691
precommit
dakinggg Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions llmfoundry/data/finetuning/dataloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,13 @@ def _build_collate_fn(
packing_ratio = auto_packing_ratio(dataloader_cfg, tokenizer,
device_batch_size)

if isinstance(packing_ratio, str):
raise ValueError(
'dataset.packing_ratio must be a float or "auto", but it was set to '
+ f'{packing_ratio}.')

log.info(f'Using packing ratio {packing_ratio}')

if packing_ratio == 1.0:
return collate_fn, device_batch_size
elif packing_ratio < 1.0:
Expand Down
1 change: 1 addition & 0 deletions llmfoundry/data/packing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,7 @@ def profile_packing(
dataloader_cfg.drop_last = False
dataloader_cfg.num_workers = 0
dataloader_cfg.prefetch_factor = None
dataloader_cfg.persistent_workers = False

# Determine the packing_ratio values we'll try
packing_ratios, raw_batch_sizes = [], []
Expand Down
Loading