Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passed metadata to mlflow logging #713

Merged
merged 24 commits into from
Nov 15, 2023

Conversation

wenfeiy-db
Copy link
Contributor

@wenfeiy-db wenfeiy-db commented Nov 3, 2023

Two fixes:

  1. The passed mlflow_logging_config is an omegaconfig DictConfig, which is not serializable by yaml and will cause mlflow logging to fail if metadata is passed there. This PR convert it to python native dict in build_callbacks.
  2. The current implementation doesn't set task key in metadata as long as metatdata is passed in mlflow_logging_config. However, it's possible for the client to pass a metatdata in mlflow_logging_config that doesn't include task key. In this case, we should keep other metadata and set the task.

@wenfeiy-db wenfeiy-db requested a review from dakinggg November 3, 2023 18:31
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you take this opportunity to improve our test coverage too? :D I'm thinking just checking that things are called with the correct args here instead of just testing that the function is called

@wenfeiy-db wenfeiy-db changed the title Set task if the passed metadata does not include task [DO NOT MERGE] Set task if the passed metadata does not include task Nov 9, 2023
@wenfeiy-db wenfeiy-db changed the title [DO NOT MERGE] Set task if the passed metadata does not include task Fix passed metadata to mlflow logging Nov 14, 2023
@wenfeiy-db wenfeiy-db requested a review from dakinggg November 15, 2023 03:51
@wenfeiy-db
Copy link
Contributor Author

@dakinggg Could you take another look? Tests added and CI is good!

@dakinggg dakinggg enabled auto-merge (squash) November 15, 2023 18:44
@dakinggg dakinggg merged commit db279d0 into mosaicml:main Nov 15, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants