Make loaded peft adapters optionally trainable #1701
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, loaded peft adapters (from HF) were not trainable. This PR adds the option to continue training peft adapters that are initialized from some existing adapter HF checkpoint.
Added unit tests to make sure adapter parameters are trainable when needed. this requires setting
pretrained=True
sincepretrained_lora_id_or_path
is only used in that case.