Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch bad split regex #1691

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Catch bad split regex #1691

wants to merge 1 commit into from

Conversation

milocress
Copy link
Contributor

Datasets throws this error:

https://github.com/huggingface/datasets/blob/661d7bac29689e2d9eb74fba3d243939d6e9f25b/src/datasets/splits.py#L362

when a split doesn't match the regex. This we catch and throw to the user.

@milocress milocress requested a review from a team as a code owner December 8, 2024 20:56
dakinggg
dakinggg reviewed Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this error doesn't need to be try/catch, shouldn't we just replace bad characters in the split or something when we write the file to disk?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milocress @dakinggg