Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error to catch more unknown example types #1562

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Add error to catch more unknown example types #1562

merged 6 commits into from
Oct 1, 2024

Conversation

milocress
Copy link
Contributor

@milocress milocress commented Sep 30, 2024 •
edited
Loading

Adds an error to catch more unknown example types

@milocress milocress requested a review from a team as a code owner September 30, 2024 21:30
snarayan21
snarayan21 reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description?

@milocress
Copy link
Contributor Author

PR description?

same as title

@milocress milocress enabled auto-merge (squash) September 30, 2024 21:39
@XiaohanZhangCMU
Copy link
Contributor

care to add a test? in case people (me:)) mess it around in the future.

@milocress milocress disabled auto-merge October 1, 2024 16:48
@milocress milocress enabled auto-merge (squash) October 1, 2024 17:17
@milocress milocress merged commit b517297 into main Oct 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snarayan21 snarayan21 snarayan21 approved these changes

@vanshcsingh vanshcsingh vanshcsingh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@milocress @XiaohanZhangCMU @vanshcsingh @snarayan21