Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release docker img #1547

Merged
merged 38 commits into from
Oct 2, 2024
Merged

Release docker img #1547

merged 38 commits into from
Oct 2, 2024

Conversation

KuuCi
Copy link
Contributor

@KuuCi KuuCi commented Sep 24, 2024

Updates the release process to also create a docker image upon hitting a tag with v*. Some parts are commented out for testing and will be reintroduced upon approval.

This was triggered off of this branch:
https://github.com/mosaicml/llm-foundry/actions/runs/11022339619/job/30611648283
image
As can be seen in the image building process, it properly clones the correct ref + repo along with all of the other installs.
image

image

@KuuCi KuuCi marked this pull request as ready for review September 24, 2024 22:52
@KuuCi KuuCi requested a review from a team as a code owner September 24, 2024 22:52
@KuuCi KuuCi requested a review from mvpatel2000 September 25, 2024 21:37
release.Dockerfile Outdated Show resolved Hide resolved
@KuuCi
Copy link
Contributor Author

KuuCi commented Sep 25, 2024

image https://github.com/mosaicml/llm-foundry/actions/runs/11041925214

^updated to use original dockerfile

@KuuCi KuuCi requested a review from mvpatel2000 September 25, 2024 23:22
Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @dakinggg plz also review

@KuuCi KuuCi requested a review from dakinggg September 30, 2024 17:33
@KuuCi
Copy link
Contributor Author

KuuCi commented Oct 1, 2024

Took me 20 commits to realize I was testing (crying internally):
mcli interactive --max-duration 1 --gpus 1 --tmux --cluster r1z2 mosaicml/llm-foundry:release_release-docker-img
instead of
mcli interactive --max-duration 1 --gpus 1 --tmux --cluster r1z2 --image mosaicml/llm-foundry:release_release-docker-img

image

@KuuCi KuuCi requested a review from dakinggg October 1, 2024 18:19
@KuuCi KuuCi requested a review from dakinggg October 1, 2024 18:39
@KuuCi KuuCi merged commit 24fec79 into main Oct 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants