Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify CL API #1510

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Simplify CL API #1510

merged 1 commit into from
Sep 30, 2024

Conversation

b-chu
Copy link
Contributor

@b-chu b-chu commented Sep 3, 2024 •
edited
Loading

Changes the API to

  • specify the dataset and use the dataloader settings from train_loader
  • not need to respecify the first dataset in the callback

Same loss curve as the old callback
image

@b-chu b-chu force-pushed the cl-api branch 2 times, most recently from d5c7eca to c9b983f Compare September 5, 2024 16:33
@b-chu b-chu marked this pull request as ready for review September 16, 2024 17:17
@b-chu b-chu requested a review from a team as a code owner September 16, 2024 17:17
mvpatel2000
mvpatel2000 reviewed Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferring to Daniel

Should @codestar12 also review

@b-chu b-chu closed this Sep 17, 2024
@b-chu b-chu reopened this Sep 18, 2024
snarayan21
snarayan21 reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind doing a before/after manual test that shows that the loss curves are the same with this change?

llmfoundry/callbacks/curriculum_learning_callback.py Show resolved Hide resolved
llmfoundry/callbacks/curriculum_learning_callback.py Outdated Show resolved Hide resolved
llmfoundry/callbacks/curriculum_learning_callback.py Show resolved Hide resolved
@mvpatel2000
Copy link
Collaborator

We should ensure @codestar12 reviews

@b-chu b-chu force-pushed the cl-api branch 2 times, most recently from 88c3023 to 9864744 Compare September 20, 2024 18:39
@b-chu b-chu merged commit bdc58b3 into main Sep 30, 2024
9 checks passed
@b-chu b-chu deleted the cl-api branch September 30, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@mvpatel2000 mvpatel2000 Awaiting requested review from mvpatel2000

@snarayan21 snarayan21 Awaiting requested review from snarayan21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@b-chu @mvpatel2000 @snarayan21 @dakinggg