Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resize embeddings fix for hf checkpointer #1422

Closed

Conversation

jdchang1
Copy link
Contributor

@jdchang1 jdchang1 commented Aug 3, 2024

Added a check to call resize token embeddings in huggingface checkpointer.

@jdchang1 jdchang1 requested a review from a team as a code owner August 3, 2024 22:52
@jdchang1 jdchang1 closed this Aug 3, 2024
@jdchang1 jdchang1 reopened this Aug 3, 2024
@dakinggg
Copy link
Collaborator

dakinggg commented Aug 5, 2024

We are discussing this PR offline to see if it is necessary

@jdchang1
Copy link
Contributor Author

jdchang1 commented Aug 5, 2024

Found a fix without needing this PR. Thank you!

@jdchang1 jdchang1 closed this Aug 5, 2024
@jdchang1 jdchang1 deleted the jchang/hf_checkpointer_resize_embedding branch August 5, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants