-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read Package Version Better #1415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor change, other than that lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Mihir Patel <[email protected]>
Weird, I initially imported However, when I ran the pre-commit hooks locally, To fix this, I added Not sure what is going on. |
In composer, streaming, and MegaBlocks, we read the package version in the
setup.py
file from the_version.py
file. However, in llm-foundry we are missing a_version.py
file and instead read the version from thellmfoundry/__init__.py
file. This PR changes this.To ensure consistency with our other repos, I put the package version in the
_version.py
file. Having a_version.py
file better follows good design principles as it is better to separate the version out into its own file.