Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support rope scaling #1391

Merged
merged 24 commits into from
Jul 24, 2024
Merged

Support rope scaling #1391

merged 24 commits into from
Jul 24, 2024

Conversation

milocress
Copy link
Contributor

@milocress milocress commented Jul 23, 2024 •
edited by dakinggg
Loading

Adds support for llama3 Rope scaling.

@milocress milocress requested a review from a team as a code owner July 23, 2024 21:08
dakinggg
dakinggg reviewed Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: when transformers 4.43.2 is released tomorrow, we should bump the min version to that in this PR

llmfoundry/models/mpt/modeling_mpt.py Outdated Show resolved Hide resolved
llmfoundry/models/mpt/modeling_mpt.py Outdated Show resolved Hide resolved
llmfoundry/models/mpt/modeling_mpt.py Outdated Show resolved Hide resolved
llmfoundry/models/mpt/modeling_mpt.py Show resolved Hide resolved
tests/models/test_rope_scaling.py Show resolved Hide resolved
snarayan21
snarayan21 reviewed Jul 24, 2024
View reviewed changes
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

llmfoundry/models/mpt/modeling_mpt.py Outdated Show resolved Hide resolved
llmfoundry/models/mpt/modeling_mpt.py Outdated Show resolved Hide resolved
tests/models/test_rope_scaling.py Show resolved Hide resolved
@milocress milocress merged commit 70586c4 into mosaicml:main Jul 24, 2024
9 checks passed
@milocress milocress deleted the milo/support-llama3-rope branch July 24, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShashankMosaicML ShashankMosaicML ShashankMosaicML left review comments

@snarayan21 snarayan21 snarayan21 left review comments

@irenedea irenedea irenedea left review comments

@dakinggg dakinggg dakinggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@milocress @irenedea @snarayan21 @dakinggg @ShashankMosaicML