Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for transforms on the model before MLFlow registration #1372

Merged
merged 17 commits into from
Jul 20, 2024
Merged

Allow for transforms on the model before MLFlow registration #1372

merged 17 commits into from
Jul 20, 2024

Conversation

snarayan21
Copy link
Contributor

@snarayan21 snarayan21 commented Jul 19, 2024 •
edited
Loading

Allows subclasses of HF Checkpointer to transform the model before MLFlow registration, if they so choose. Also slight change to make using_peft an attribute of HF Checkpointer instance, allowing it to be used / set.

@snarayan21 snarayan21 requested a review from a team as a code owner July 19, 2024 08:19
@snarayan21 snarayan21 requested review from irenedea and dakinggg July 19, 2024 08:23
snarayan21
snarayan21 commented Jul 19, 2024
View reviewed changes
Copy link
Contributor Author

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note

llmfoundry/callbacks/hf_checkpointer.py Show resolved Hide resolved
dakinggg
dakinggg reviewed Jul 19, 2024
View reviewed changes
llmfoundry/callbacks/hf_checkpointer.py Outdated Show resolved Hide resolved
llmfoundry/callbacks/hf_checkpointer.py Outdated Show resolved Hide resolved
llmfoundry/callbacks/hf_checkpointer.py Show resolved Hide resolved
llmfoundry/callbacks/hf_checkpointer.py Outdated Show resolved Hide resolved
@snarayan21 snarayan21 requested a review from dakinggg July 20, 2024 04:08
dakinggg
dakinggg approved these changes Jul 20, 2024
View reviewed changes
llmfoundry/callbacks/hf_checkpointer.py Show resolved Hide resolved
llmfoundry/callbacks/hf_checkpointer.py Outdated Show resolved Hide resolved
llmfoundry/callbacks/hf_checkpointer.py Outdated Show resolved Hide resolved
@snarayan21 snarayan21 enabled auto-merge (squash) July 20, 2024 04:54
@snarayan21 snarayan21 merged commit feb786c into main Jul 20, 2024
9 checks passed
@dakinggg dakinggg deleted the saaketh/pre_reg_transforms branch August 6, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@irenedea irenedea Awaiting requested review from irenedea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snarayan21 @dakinggg