-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dockerfile with TE main #1273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please post manual test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM please hold until after DAIS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking for now
Is this an issue?
|
Nope, we ignore the FP8 extra_state upon load time with |
Update Dockerfile with TE main to resolve torch 2.3.0 build issues
Manual Tests:
bs-12-weight-shard-fp8-llama3-8b-metamath-4ep-ZaOqHP
✅torch-231-bs-12-weight-shard-fp8-llama3-8b-metamath-4ep-lS8jLE
✅Docker build: