Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added systemMetricsMonitor callback #1260

Merged
merged 10 commits into from
Jun 19, 2024
Merged

added systemMetricsMonitor callback #1260

merged 10 commits into from
Jun 19, 2024
+17 −0

Conversation

JackZ-db
Copy link
Contributor

@JackZ-db JackZ-db commented Jun 6, 2024

Added systemMetricsMonitor callback from Composer to LLM-Foundry.

@JackZ-db JackZ-db requested a review from a team as a code owner June 6, 2024 21:45
@JackZ-db JackZ-db self-assigned this Jun 6, 2024
@JackZ-db JackZ-db requested a review from j316chuck June 6, 2024 21:46
dakinggg
dakinggg reviewed Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test that tests constructing the callback

@j316chuck
Copy link
Contributor

LG barring unit tests

mvpatel2000
mvpatel2000 reviewed Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM barring unit test

dakinggg
dakinggg approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JackZ-db in the future, you can rerequest review once you've addressed the feedback! Sorry, didn't notice it was ready.

@JackZ-db JackZ-db merged commit 4b1fecb into mosaicml:main Jun 19, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 left review comments

@dakinggg dakinggg dakinggg approved these changes

@j316chuck j316chuck Awaiting requested review from j316chuck

Assignees

@JackZ-db JackZ-db

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JackZ-db @j316chuck @mvpatel2000 @dakinggg