Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HF conversion automatically add missing imports #1241

Merged
merged 7 commits into from
May 29, 2024

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented May 27, 2024

This PR removes the need for manually importing everything in the modeling file, by automatically including the missing imports needed for HF.

@dakinggg dakinggg marked this pull request as ready for review May 27, 2024 08:24
@dakinggg dakinggg requested review from mvpatel2000 and irenedea May 27, 2024 08:24
Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@dakinggg dakinggg merged commit b82a82b into mosaicml:main May 29, 2024
9 checks passed
@dakinggg dakinggg deleted the hf-auto-include branch June 22, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants