Updating the streaming version in setup.py #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we adde |
Done. PTAL. |
snarayan21
reviewed
Apr 9, 2024
There was a problem hiding this comment.
Can you add the allow_unsafe_types and replication args as arguments to the StreamingTextDataset and StreamingFinetuningDataset init functions as well? What's the rationale for passing in fixed values? If I want to set replication from my yaml, for example, this isn't possible right
vchiley
reviewed
Apr 9, 2024
Done. Ptal. |
vchiley
approved these changes
Apr 9, 2024
KuuCi
pushed a commit
that referenced
this pull request
Apr 18, 2024
* updating the streaming version in setup.py * updating constructor call to StreamingDataset * making allow_unsafe_types and replication configurable through dataset configs * adding docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.