Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Param init registry #1096

Merged
merged 22 commits into from
Apr 13, 2024
Merged

Param init registry #1096

merged 22 commits into from
Apr 13, 2024

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Apr 4, 2024 •
edited
Loading

Before and after:
Screenshot 2024-04-04 at 7 15 23 PM
Screenshot 2024-04-04 at 7 14 24 PM

@dakinggg dakinggg marked this pull request as ready for review April 5, 2024 02:16
@dakinggg dakinggg requested review from irenedea and mvpatel2000 April 5, 2024 02:20
@dakinggg
Copy link
Collaborator Author

With MB merge:

Screenshot 2024-04-11 at 8 22 57 PM Screenshot 2024-04-11 at 8 23 24 PM

@irenedea @mvpatel2000 this one is ready

@dakinggg
Copy link
Collaborator Author

jk, a test failed, need to debug

@dakinggg
Copy link
Collaborator Author

ok @mvpatel2000 tests passing now

@dakinggg dakinggg merged commit 676ad7f into mosaicml:main Apr 13, 2024
9 checks passed
KuuCi pushed a commit that referenced this pull request Apr 18, 2024
@dakinggg @KuuCi
Param init registry (#1096)
825f1a5
@dakinggg dakinggg deleted the init-registry branch June 22, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

@irenedea irenedea Awaiting requested review from irenedea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dakinggg @mvpatel2000