Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleaned up HF/MPT conversion test #1048

Merged
merged 19 commits into from
Apr 4, 2024
Merged

cleaned up HF/MPT conversion test #1048

merged 19 commits into from
Apr 4, 2024

Conversation

milocress
Copy link
Contributor

I forgot to follow up on this PR: #950

It was so out of date that I quickly rewrote it.

@milocress milocress changed the title cleaned up test cleaned up HF/MPT conversion test Mar 21, 2024
@milocress milocress mentioned this pull request Mar 21, 2024
Closed
dakinggg
dakinggg reviewed Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to use the new helpers in test_huggingface_conversion_callback_interval also?

tests/a_scripts/inference/test_convert_composer_to_hf.py Outdated Show resolved Hide resolved
tests/a_scripts/inference/test_convert_composer_to_hf.py Outdated Show resolved Hide resolved
@milocress milocress requested a review from dakinggg March 25, 2024 17:43
@dakinggg
Copy link
Collaborator

@milocress did you see my other comment asking if you wanted to also change test_huggingface_conversion_callback_interval to use the new helpers?

@milocress
Copy link
Contributor Author

milocress commented Mar 26, 2024 •
edited
Loading

@milocress did you see my other comment asking if you wanted to also change test_huggingface_conversion_callback_interval to use the new helpers?

oops good catch let me take a look

edit: looks like the only overlap in terms of helper functions is the optimizer config - I updated the tests so that both of these share a common optimizer config

@dakinggg dakinggg enabled auto-merge (squash) April 4, 2024 21:30
@dakinggg dakinggg merged commit 94301cd into mosaicml:main Apr 4, 2024
9 checks passed
KuuCi pushed a commit that referenced this pull request Apr 18, 2024
@milocress @KuuCi
cleaned up HF/MPT conversion test (#1048)
e3ee8e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milocress @dakinggg