fix

mosaicml · Apr 10, 2024 · 7669954 · 7669954
1 parent 53889fd
commit 7669954
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/llmfoundry/utils/builders.py b/llmfoundry/utils/builders.py
@@ -388,7 +388,7 @@ def build_optimizer(
             'optimizer config. Please remove it from the optimizer config kwargs.'
         )
 
-    kwargs['params'] = list(params)
+    kwargs['params'] = params
     return construct_from_registry(name=name,
                                    registry=registry.optimizers,
                                    partial_function=True,

diff --git a/scripts/train/train.py b/scripts/train/train.py
@@ -259,9 +259,9 @@ def main(cfg: DictConfig) -> Trainer:
 
     # Mandatory model training configs
     model_config: DictConfig = DictConfig(scfg.model)
-    tokenizer_config: Dict[str, Any] = scfg.tokenizer
-    optimizer_config: Dict[str, Any] = scfg.optimizer
-    scheduler_config: Dict[str, Any] = scfg.scheduler
+    tokenizer_config: Dict[str, Any] = {**scfg.tokenizer}
+    optimizer_config: Dict[str, Any] = {**scfg.optimizer}
+    scheduler_config: Dict[str, Any] = {**scfg.scheduler}
     train_loader_config: DictConfig = DictConfig(scfg.train_loader)
 
     # Optional fsdp data, fine-tuning, and eval configs