Skip to content

Commit

Permalink
change defaults
Browse files Browse the repository at this point in the history
  • Loading branch information
maxisawesome committed Feb 12, 2024
1 parent 124b60a commit 6b37a8c
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions llmfoundry/utils/builders.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def build_evaluators(
device_eval_batch_size: int,
icl_seq_len: int,
icl_subset_num_batches: Optional[int],
fewshot_random_seed: Optional[int] = None,
fewshot_random_seed: Optional[int] = 1234,

This comment has been minimized.

Copy link
@dakinggg

dakinggg Feb 12, 2024

Collaborator

change type if its not optional anymore

) -> Tuple[List[Evaluator], List[str], Optional[EvalGauntlet]]:

evaluators = []
Expand Down Expand Up @@ -130,7 +130,7 @@ def build_icl_data_and_gauntlet(
tokenizer: PreTrainedTokenizerBase,
device_eval_batch_size: int,
icl_seq_len: int,
fewshot_random_seed: Optional[int],
fewshot_random_seed: Optional[int] = 1234,
icl_subset_num_batches: Optional[int] = None
) -> Tuple[List[Evaluator], List[str], Optional[EvalGauntlet]]:
icl_evaluators, logger_keys = build_icl_evaluators(
Expand Down Expand Up @@ -446,7 +446,7 @@ def build_icl_evaluators(
default_max_seq_len: int,
default_batch_size: int,
destination_dir: Optional[str] = None,
fewshot_random_seed: Optional[int] = None,
fewshot_random_seed: Optional[int] = 1234,
icl_subset_num_batches: Optional[int] = None,
) -> Tuple[List[Evaluator], List[str]]:
if destination_dir is None:
Expand Down

0 comments on commit 6b37a8c

Please sign in to comment.