Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Daniel King <[email protected]>
  • Loading branch information
aspfohl and dakinggg authored Nov 13, 2023
1 parent 3358837 commit 28e47df
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions llmfoundry/callbacks/async_eval_callback.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def get_load_path(save_folder: str,
save_latest_filename: Optional[str] = None) -> str:
# TODO: check that the prefix is remote and not a local file (not supported of course)

if not save_latest_filename:
if save_latest_filename is None:
rank = dist.get_global_rank()
save_latest_filename = f'latest-rank{rank}.pt'

Expand Down Expand Up @@ -90,7 +90,7 @@ class AsyncEval(Callback):
:attr:`.TimeUnit.TOKEN`, or :attr:`.TimeUnit.SAMPLE`.
compute: Optional[Union[ComputeConfig, Dict[str, Any]]]: The compute configuration to
use for the eval run. If not provided, the same cluster as the current run and a
single GPU node will be used.
single, full GPU node will be used.
"""

def __init__(
Expand Down

0 comments on commit 28e47df

Please sign in to comment.