Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version bump to 0.24.0 #3527

Closed
wants to merge 4 commits into from
Closed

version bump to 0.24.0 #3527

wants to merge 4 commits into from

Conversation

eracah
Copy link
Contributor

@eracah eracah commented Aug 7, 2024

bump version

@eracah eracah requested a review from a team as a code owner August 7, 2024 00:00
@antoinebrl
Copy link
Contributor

Hello! Should this version be compatible with torch 2.4?

@mvpatel2000
Copy link
Contributor

Hello! Should this version be compatible with torch 2.4?

Unfortunately, no -- there is some complexity we're hitting with bump and monkeypatches. We're going to do a follow-up release that will include it CC: @j316chuck

@antoinebrl
Copy link
Contributor

@mvpatel2000 Thanks for sharing the details! 👍 We will adjust our plan accordingly.

@eracah eracah force-pushed the bump_version_v0.24.0 branch from 95c6722 to be28725 Compare August 13, 2024 18:44
@snarayan21 snarayan21 force-pushed the bump_version_v0.24.0 branch from e51f639 to 416a1b7 Compare August 22, 2024 22:08
@snarayan21 snarayan21 requested a review from bigning August 22, 2024 22:17
@snarayan21
Copy link
Contributor

Taking over this PR from @eracah.

@mvpatel2000 @bigning one thing to note -- I'm completely removing create_fsdp_config function since the functionality has been completely deprecated. Just wanted to call attention to that and make sure it's good with y'all.

Running dailies: https://github.com/mosaicml/composer/actions/runs/10516433172

@snarayan21
Copy link
Contributor

Closing in favor of #3570

@snarayan21 snarayan21 closed this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants