Add SHARD_GRAD_OP to device mesh error check #3058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvpatel2000
requested review from
dakinggg,
eracah,
j316chuck,
b-chu,
josejg,
milocress and
KuuCi
b-chu
approved these changes
Feb 26, 2024
mvpatel2000
force-pushed
the
mvpatel2000/raise-error
branch
from
954c21a to
54171a5
Compare
j316chuck
pushed a commit
that referenced
this pull request
Mar 29, 2024
* fix tests * fi xerror * fix
j316chuck
pushed a commit
that referenced
this pull request
May 16, 2024
* fix tests * fi xerror * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add SHARD_GRAD_OP to device mesh error check. Avoids nasty torch error if user incorrectly specifies mesh shard combo