Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename composer_run_name tag to run_name when logging to MLflow #3040

Merged
merged 7 commits into from
Feb 23, 2024
Merged

Rename composer_run_name tag to run_name when logging to MLflow #3040

merged 7 commits into from
Feb 23, 2024

Conversation

jerrychen109
Copy link
Contributor

What does this PR do?

Rename composer_run_name tag in MLflow to just run_name

image

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@jerrychen109 jerrychen109 requested a review from a team as a code owner February 20, 2024 22:52
@jerrychen109 jerrychen109 enabled auto-merge (squash) February 22, 2024 01:49
dakinggg
dakinggg requested changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

until tested

@jerrychen109
Copy link
Contributor Author

@dakinggg Actually added a unit test instead of YOLOing with github unit tests

@jerrychen109 jerrychen109 merged commit d5692e4 into dev Feb 23, 2024
14 checks passed
@jerrychen109 jerrychen109 deleted the jerry/mlflow-run-name-tag branch February 23, 2024 01:23
j316chuck pushed a commit that referenced this pull request Mar 29, 2024
@jerrychen109 @j316chuck
Rename composer_run_name tag to run_name when logging to MLflow (#3040)
9fe660c 
* Rename composer_run_name tag to run_name when logging to MLflow

* backwards compatibility
j316chuck pushed a commit that referenced this pull request May 16, 2024
@jerrychen109
Rename composer_run_name tag to run_name when logging to MLflow (#3040)
6b5e5a5 
* Rename composer_run_name tag to run_name when logging to MLflow

* backwards compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerrychen109 @mvpatel2000 @dakinggg