Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use current year in license #2825

Closed
wants to merge 2 commits into from
Closed

Use current year in license #2825

wants to merge 2 commits into from

Conversation

aspfohl
Copy link
Contributor

@aspfohl aspfohl commented Jan 8, 2024

What does this PR do?

mosaicml/llm-foundry#835

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@aspfohl aspfohl requested review from a team, eracah, dakinggg and dblalock as code owners January 8, 2024 16:38
@hanlint
Copy link
Contributor

hanlint commented Jan 8, 2024

Is it neccessary to keep licenses up to date to the year? I see many stale years in the tensorflow and torch repositories. I feel this introduces unneccessary commit / change noise -- all our files will have their last change preview in github reset.

@mvpatel2000 mvpatel2000 self-requested a review January 8, 2024 16:45
@aspfohl
Copy link
Contributor Author

aspfohl commented Jan 8, 2024

Is it neccessary to keep licenses up to date to the year? I see many stale years in the tensorflow and torch repositories. I feel this introduces unneccessary commit / change noise -- all our files will have their last change preview in github reset.

Yea this is fair.. Originally added because I was getting linting errors when using the most up to date year, was slightly annoying to have to arbitrarily set it to 2022 🙃

It's probably worth looking into if there's other libraries that do this successfully.. ideally there would be a setting on the license checking library that allows out of date years (doesnt change all the files) but uses the most current year to generate new files. Going to close for now and reopen if theres time or I run across a better solution 😛

@aspfohl aspfohl closed this Jan 8, 2024
@aspfohl aspfohl deleted the anna/license-updates branch January 8, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants