-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip -> uv #22
Conversation
Two comments:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uv requires venv, so these changes seem sensible
a bit confused why we need site packages but that seems minor
approving to unblock but would be good to resolve that small q
@eitanturok both your statements are true, I was just trying to do the simplest change that would have benefit because making CI changes is difficult and annoying. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok we ball
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Replace pip with uv. This reduces the time every action takes by 3-4 minutes because uv is just that much faster at installing things. Tested this PR against LLM Foundry (last commit here) and an internal repo to ensure it works. I do not fully understand the specific incantations that were needed to get everything to install correctly...but it does seem to work.