Skip to content

Commit

Permalink
Remove setting S3_bucket (#4)
Browse files Browse the repository at this point in the history
Composer daily test now depend on the environment variable as a result of this PR
https://github.com/mosaicml/composer/pull/3097/files#diff-9b51bddca1ee6939e679688418a5d0a0ff1e66cf6df7b10df1d015d1134972c0R116

This change sets the env var to None instead of an empty string to correctly get the right bucket
  • Loading branch information
b-chu authored Mar 13, 2024
1 parent 635302c commit 27e71f6
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion .github/workflows/pytest-cpu.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ jobs:
export GCS_SECRET='${{ secrets.gcs-secret }}'
export AZURE_ACCOUNT_NAME='${{ secrets.azure-account-name }}'
export AZURE_ACCOUNT_ACCESS_KEY='${{ secrets.azure-account-access-key }}'
export S3_BUCKET='${{ inputs.pytest-s3-bucket }}'
export COMMON_ARGS="-v --durations=20 -m '${{ inputs.pytest-markers }}' -o tmp_path_retention_policy=none"
# Necessary to run git diff for doctests
Expand Down

0 comments on commit 27e71f6

Please sign in to comment.