Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a weekly file pattern. #17

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Add a weekly file pattern. #17

merged 1 commit into from
Aug 10, 2020

Conversation

torotil
Copy link
Contributor

@torotil torotil commented Aug 4, 2020

No description provided.

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #17 into 7.x-1.x will increase coverage by 0.39%.
The diff coverage is 90.90%.

Impacted file tree graph

@@              Coverage Diff              @@
##             7.x-1.x      #17      +/-   ##
=============================================
+ Coverage      65.23%   65.63%   +0.39%     
- Complexity       202      205       +3     
=============================================
  Files             37       38       +1     
  Lines            699      710      +11     
=============================================
+ Hits             456      466      +10     
- Misses           243      244       +1     
Impacted Files Coverage Δ Complexity Δ
src/Files/WeeklyFilePattern.php 90.90% <90.90%> (ø) 3.00 <3.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e5bf68...f718336. Read the comment docs.

Copy link
Contributor

@katzmo katzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it’s save to assume a week should always start on Monday? But since that’s ISO standard it’s certainly a good default.

@torotil
Copy link
Contributor Author

torotil commented Aug 5, 2020

Not sure it’s save to assume a week should always start on Monday? But since that’s ISO standard it’s certainly a good default.

That’s what I thought as well. There is also a few issues that need resolving to make all this more extensible eg. #18 #19 that’s why I thought optimising this has not such a high priority in comparison.

@torotil torotil merged commit 6368445 into 7.x-1.x Aug 10, 2020
@torotil torotil deleted the weekly branch August 10, 2020 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants