Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support tracks without a valid duration, e.g. musepack #70

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

support tracks without a valid duration, e.g. musepack #70

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
181dff9
support tracks without a valid duration, e.g. musepack
schmaller Dec 12, 2022
ffe3ba7
comply to the linter rules
schmaller Feb 13, 2023
9d690de
Merge branch 'mopidy:master' into musepack-scanning
schmaller Feb 14, 2023
acdf4fa
Merge branch 'mopidy:main' into musepack-scanning
schmaller Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions mopidy_local/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,17 +221,17 @@
logger.warning(
f"Failed scanning {file_uri}: No audio found in file"
)
elif result.duration is None:
logger.warning(
f"Failed scanning {file_uri}: "
"No duration information found in file"
)
elif result.duration < MIN_DURATION_MS:
elif result.duration and result.duration < MIN_DURATION_MS:

Check warning on line 224 in mopidy_local/commands.py

View check run for this annotation

Codecov / codecov/patch

mopidy_local/commands.py#L224 

Added line #L224 was not covered by tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case, this change will now let duration 0 pass and skip through all checks because it's not None and it's falsey

logger.warning(
f"Failed scanning {file_uri}: "
f"Track shorter than {MIN_DURATION_MS}ms"
)
else:
if result.duration is None:
logger.warning(

Check warning on line 231 in mopidy_local/commands.py

View check run for this annotation

Codecov / codecov/patch

mopidy_local/commands.py#L230-L231 

Added lines #L230 - L231 were not covered by tests
f"Failed scanning {file_uri}: "
"proceeding without duration information"
)
local_uri = translator.path_to_local_track_uri(
absolute_path, media_dir
)
Expand Down