Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes #45

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Small fixes #45

merged 3 commits into from
Jan 22, 2024

Commits on Jan 22, 2024

  1. fix: use timeout (4 seconds) for HTTP requests 

    Previously no timeout was used at all.
This surely lead to some usability issues in case of temporary network
problems.
    @sumpfralle
    sumpfralle committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    27dd64d View commit details
    Browse the repository at this point in the history

  2. fix: do not memorize initial connection failure 

    Previously during the extension setup a connection was attempted once
and the success state of this attempt was memorized.
In later search queries a stored failure caused the backend query to be
skipped.

This lead to two problems:
* Not all requests took the initial connection test result into account
  (i.e. some queries were skipped and some were not).
* The initial connection test result was not updated during the life
  time of the extension (i.e. until the next restart of Mopidy).
  Thus, a broken connection could never recover.
    @sumpfralle
    sumpfralle committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    bbada91 View commit details
    Browse the repository at this point in the history

  3. fix: allow browsing by album year 

    The listing was broken since commit 1e9ca37.
Now we enforce the string conversion for browse item names again.
    @sumpfralle
    sumpfralle committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    0df7756 View commit details
    Browse the repository at this point in the history